From: remitamine <remitamine@gmail.com>
Date: Fri, 4 Sep 2015 19:07:36 +0000 (+0100)
Subject: [downloader/external] add _bool_option to pass value to bool option
X-Git-Url: http://git.oshgnacknak.de/?a=commitdiff_plain;h=266b0ad6762eaa48156b021094126062cb9f44d6;p=youtube-dl

[downloader/external] add _bool_option to pass value to bool option
---

diff --git a/youtube_dl/downloader/external.py b/youtube_dl/downloader/external.py
index 072ac3a46..22dfd2833 100644
--- a/youtube_dl/downloader/external.py
+++ b/youtube_dl/downloader/external.py
@@ -53,6 +53,14 @@ class ExternalFD(FileDownloader):
             return [command_option]
         return [command_option, param]
 
+    def _bool_option(self, command_option, param, true_value='true', false_value='false', separator=None):
+        param = self.params.get(param)
+        if not isinstance(param, bool):
+            return []
+        if separator:
+            return [command_option + separator + (true_value if param else false_value)]
+        return [command_option, true_value if param else false_value]
+
     def _configuration_args(self, default=[]):
         ex_args = self.params.get('external_downloader_args')
         if ex_args is None:
@@ -123,7 +131,7 @@ class Aria2cFD(ExternalFD):
             cmd += ['--header', '%s: %s' % (key, val)]
         cmd += self._option('--interface', 'source_address')
         cmd += self._option('--all-proxy', 'proxy')
-        cmd += self._option('--check-certificate=false', 'nocheckcertificate')
+        cmd += self._bool_option('--check-certificate', 'nocheckcertificate', 'false', 'true', '=')
         cmd += ['--', info_dict['url']]
         return cmd