From: Yen Chi Hsuan <yan12125@gmail.com>
Date: Tue, 3 May 2016 07:37:30 +0000 (+0800)
Subject: [utils] Add rationale for register_socks_protocols
X-Git-Url: http://git.oshgnacknak.de/?a=commitdiff_plain;h=d5ae6bb50124f8320f2b492380480038c487a6d2;p=youtube-dl

[utils] Add rationale for register_socks_protocols
---

diff --git a/youtube_dl/utils.py b/youtube_dl/utils.py
index c9702fd93..dc73f3407 100644
--- a/youtube_dl/utils.py
+++ b/youtube_dl/utils.py
@@ -63,6 +63,8 @@ from .socks import (
 
 def register_socks_protocols():
     # "Register" SOCKS protocols
+    # In Python < 2.6.5, urlsplit() suffers from bug https://bugs.python.org/issue7904
+    # URLs with protocols not in urlparse.uses_netloc are not handled correctly
     for scheme in ('socks', 'socks4', 'socks4a', 'socks5'):
         if scheme not in compat_urlparse.uses_netloc:
             compat_urlparse.uses_netloc.append(scheme)