[utils] Unquote crendentials passed to SOCKS proxies
authorYen Chi Hsuan <yan12125@gmail.com>
Thu, 12 May 2016 10:57:53 +0000 (18:57 +0800)
committerYen Chi Hsuan <yan12125@gmail.com>
Thu, 12 May 2016 16:27:25 +0000 (00:27 +0800)
Fixes #9450

youtube_dl/utils.py

index 6592c8ec29069ed418175ddbb8c4c1234cf5696d..d6f94f8cd2b620f786e33ce73ae685eaf3c48497 100644 (file)
@@ -50,6 +50,7 @@ from .compat import (
     compat_urllib_parse,
     compat_urllib_parse_urlencode,
     compat_urllib_parse_urlparse,
+    compat_urllib_parse_unquote_plus,
     compat_urllib_request,
     compat_urlparse,
     compat_xpath,
@@ -886,7 +887,8 @@ def make_socks_conn_class(base_class, socks_proxy):
         socks_type,
         url_components.hostname, url_components.port or 1080,
         True,  # Remote DNS
-        url_components.username, url_components.password
+        compat_urllib_parse_unquote_plus(url_components.username),
+        compat_urllib_parse_unquote_plus(url_components.password),
     )
 
     class SocksConnection(base_class):