Re-engineered XNXXIE to actually exit on ERRORs even with -i

diff --git a/youtube-dl b/youtube-dl
index 448b2cd2667738716d7fc05e26f35ef59554fcb2..a7c5ee6f942b4b0770c17fccfa333fdd487a2ed7 100755 (executable)
Binary files a/youtube-dl and b/youtube-dl differ

diff --git a/youtube-dl.exe b/youtube-dl.exe
index b7123fc168c815f3d01964db2aaa9de755b9b44f..fbed2841adb374f635f305da73d93085f6f43980 100755 (executable)
Binary files a/youtube-dl.exe and b/youtube-dl.exe differ

diff --git a/youtube_dl/InfoExtractors.py b/youtube_dl/InfoExtractors.py
index 2b313966fd35a69f338f9d8ee1024c4bdbaa3064..6c4a1b1f1f4445a25e192c9a94cb5024fd2603e5 100644 (file)
--- a/youtube_dl/InfoExtractors.py
+++ b/youtube_dl/InfoExtractors.py
@@ -3098,30 +3098,6 @@ class XNXXIE(InfoExtractor):
                """Report information extraction"""
                self._downloader.to_screen(u'[%s] %s: Extracting information' % (self.IE_NAME, video_id))
 
-       def extract_video_url(self, webpage):
-               "Extract the url for the video from the webpage"
-               
-               result = re.search(self.VIDEO_URL_RE, webpage)
-               if result is None:
-                       self._downloader.trouble(u'ERROR: unable to extract video url')
-               return urllib.unquote(result.group(1).decode('utf-8'))
-
-       def extract_video_title(self, webpage):
-               "Extract the title for the video from the webpage"
-
-               result = re.search(self.VIDEO_TITLE_RE, webpage)
-               if result is None:
-                       self._downloader.trouble(u'ERROR: unable to extract video title')
-               return result.group(1).decode('utf-8')
-
-       def extract_video_thumbnail(self, webpage):
-               "Extract the thumbnail for the video from the webpage"
-
-               result = re.search(self.VIDEO_THUMB_RE, webpage)
-               if result is None:
-                       self._downloader.trouble(u'ERROR: unable to extract video thumbnail')
-               return result.group(1).decode('utf-8')
-
        def _real_extract(self, url):
                mobj = re.match(self._VALID_URL, url)
                if mobj is None:
@@ -3138,14 +3114,32 @@ class XNXXIE(InfoExtractor):
                        self._downloader.trouble(u'ERROR: unable to download video webpage: %s' % err)
                        return
 
+               result = re.search(self.VIDEO_URL_RE, webpage)
+               if result is None:
+                       self._downloader.trouble(u'ERROR: unable to extract video url')
+                       return
+               video_url = urllib.unquote(result.group(1).decode('utf-8'))
+
+               result = re.search(self.VIDEO_TITLE_RE, webpage)
+               if result is None:
+                       self._downloader.trouble(u'ERROR: unable to extract video title')
+                       return
+               video_title = result.group(1).decode('utf-8')
+
+               result = re.search(self.VIDEO_THUMB_RE, webpage)
+               if result is None:
+                       self._downloader.trouble(u'ERROR: unable to extract video thumbnail')
+                       return
+               video_thumbnail = result.group(1).decode('utf-8')
+
                info = {'id': video_id,
-                               'url': self.extract_video_url(webpage),
+                               'url': video_url,
                                'uploader': None,
                                'upload_date': None,
-                               'title': self.extract_video_title(webpage),
+                               'title': video_title,
                                'ext': 'flv',
                                'format': 'flv',
-                               'thumbnail': self.extract_video_thumbnail(webpage),
+                               'thumbnail': video_thumbnail,
                                'description': None,
                                'player_url': None}