From: Sergey M․ <dstftw@gmail.com>
Date: Sat, 6 Feb 2016 17:24:22 +0000 (+0600)
Subject: [downloader/hls] Do not send 'q' to ffmpeg on Windows (Closes #8300)
X-Git-Url: http://git.oshgnacknak.de/?a=commitdiff_plain;h=56401e1e5f53e126bf124699b2f62bb670078fd3;p=youtube-dl

[downloader/hls] Do not send 'q' to ffmpeg on Windows (Closes #8300)
---

diff --git a/youtube_dl/downloader/hls.py b/youtube_dl/downloader/hls.py
index cb34dc4ab..2a775bf00 100644
--- a/youtube_dl/downloader/hls.py
+++ b/youtube_dl/downloader/hls.py
@@ -3,6 +3,7 @@ from __future__ import unicode_literals
 import os
 import re
 import subprocess
+import sys
 
 from .common import FileDownloader
 from .fragment import FragmentFD
@@ -57,8 +58,10 @@ class HlsFD(FileDownloader):
             # subprocces.run would send the SIGKILL signal to ffmpeg and the
             # mp4 file couldn't be played, but if we ask ffmpeg to quit it
             # produces a file that is playable (this is mostly useful for live
-            # streams)
-            proc.communicate(b'q')
+            # streams). Note that Windows is not affected and produces playable
+            # files (see https://github.com/rg3/youtube-dl/issues/8300).
+            if sys.platform != 'win32':
+                proc.communicate(b'q')
             raise
         if retval == 0:
             fsize = os.path.getsize(encodeFilename(tmpfilename))