youtube-dl

commit e034cbc581c79b14c6337adf51bf4a99f726302d
parent 69c2d42bd730b4ea07fe5ba9015049423b71c8a9
Author: Yen Chi Hsuan <yan12125@gmail.com>
Date:   Sat, 22 Oct 2016 13:10:27 +0800

Merge branch 'johnhawkinson-stdin2'

Diffstat:
M
ChangeLog
 | 
6
++++++
M
youtube_dl/utils.py
 | 
4
++++

2 files changed, 10 insertions(+), 0 deletions(-)
diff --git a/ChangeLog b/ChangeLog
@@ -1,3 +1,9 @@
+version <unreleased>
+
+Core
+* Running youtube-dl in the background is fixed (#10996, #10706, #955)
+
+
 version 2016.10.21.1
 
 Extractors
diff --git a/youtube_dl/utils.py b/youtube_dl/utils.py
@@ -1818,8 +1818,12 @@ def get_exe_version(exe, args=['--version'],
     """ Returns the version of the specified executable,
     or False if the executable is not present """
     try:
+        # STDIN should be redirected too. On UNIX-like systems, ffmpeg triggers
+        # SIGTTOU if youtube-dl is run in the background.
+        # See https://github.com/rg3/youtube-dl/issues/955#issuecomment-209789656
         out, _ = subprocess.Popen(
             [encodeArgument(exe)] + args,
+            stdin=subprocess.PIPE,
             stdout=subprocess.PIPE, stderr=subprocess.STDOUT).communicate()
     except OSError:
         return False